Celebrating My Second Pull Request

2025-09-19

Today I finally opened my second upstream pull request! After a full rebase-and-polish session in the openai/codex repository, the branch feature/textarea-ctrl-pn is now live as PR #3944.

This one felt especially meaningful because I already had the muscle memory from my very first PR to the open-source world: weapp-vite#175. That initial contribution taught me the value of reading existing conventions carefully and double-checking formatting before pushing. Today I put those lessons to good use:

• Introduced Ctrl+P / Ctrl+N navigation to the Codex TUI composer and to every list-selection popup, matching the shortcuts I rely on in Emacs.
• Added comprehensive unit coverage so the bindings work across terminals, even when the Control modifier is delivered as raw C0 bytes.
• Re-ran formatting, linting, and the entire codex-tui test suite until everything was green.

It took two attempts to get here. The first PR in this repo stalled after I realized the shortcuts were missing in other UI components. Coming back with a fresh plan, I took the time to extend the behaviour consistently and document it clearly in the PR notes. The CLA bot even recognised me immediately this time—progress!

Small victories like this keep me motivated. Here’s to many more thoughtful contributions and to sharing what I learn along the way.